Skip to content

Conversation

@Den-dp
Copy link

@Den-dp Den-dp commented Nov 22, 2021

BREAKING CHANGE: Require Node.js 8 as per https://github.com/chalk/strip-ansi/releases/tag/v6.0.0

Closes: #108

@Den-dp
Copy link
Author

Den-dp commented Nov 22, 2021

According to CI results, I see that node 6, 7, 8 jobs didn't even run:
https://app.travis-ci.com/github/litixsoft/karma-mocha-reporter/jobs/549146573#L292

Node 4 and 5 jobs failed because it can't install deps (missing package-lock.json pays off):
https://app.travis-ci.com/github/litixsoft/karma-mocha-reporter/jobs/549146569#L320

@Den-dp Den-dp mentioned this pull request Dec 6, 2021
Dropping support for nodejs<=8 in CI, since `package.json` specifies to install the latest karma, and it doesn't support old nodejs https://github.com/karma-runner/karma/blob/master/CHANGELOG.md#500-2020-04-09
@Den-dp Den-dp force-pushed the fix/update-strip-ansi branch from 85c68f4 to fd2d701 Compare December 15, 2021 12:12
@Den-dp
Copy link
Author

Den-dp commented Dec 15, 2021

Ok, I fixed tests by dropping CI builds on nodejs<=10.
This requirement came from the fact that this repo configured to use the latest karma, and in karma@5 they dropped nodejs@8 https://github.com/karma-runner/karma/blob/master/CHANGELOG.md#500-2020-04-09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm audit ansi-regex

1 participant